Adam Kelly

Results 15 comments of Adam Kelly

Hello - thanks for your fix. We do want to move to C++ stdlib calls, but have had to move slowly because of the number of platforms we support. @wjblanke...

Cool, if you land first, I'll redo the PR. Either way.

Moved to https://github.com/Chia-Network/chia-blockchain/pull/13645

Thank you for the reports. I'll start looking at this in the wallet code now.

Yes, just to make it quicker to re-run. Thanks!

That's a lot nicer! https://github.com/Chia-Network/chia-blockchain/pull/16083/files#diff-bbecd16d727921b84038345b2389c82e06030aac1a205108c02d932bf62e596bR1238

Coverage warning https://github.com/Chia-Network/chia-blockchain/actions/runs/6434749575/job/17475576769 tests/wallet/nft_wallet/test_nft_1_offers.py (0.0%): Missing lines 1238,1240-1241,1449

> it makes me a bit uneasy that the cache doesn't update by itself and that it's checked in. It seems like something we could keep in the `test-cache` repo...

Thank you both for the constructive comments; I'll ping you when it has all the updates.