chiapos icon indicating copy to clipboard operation
chiapos copied to clipboard

Move final file if in same file system, not only in same directory

Open aydreas opened this issue 4 years ago • 4 comments

Use std::filesystem::equivalent instead of just comparing the parent directories to determine if tmp_2_file can be moved. Prevents useless IO activity and speeds up plotting if temp_2_file and final_file are in the same file system.

aydreas avatar Apr 21 '21 17:04 aydreas

Hello - thanks for your fix. We do want to move to C++ stdlib calls, but have had to move slowly because of the number of platforms we support.

@wjblanke will this work on the oldest macos we currently support?

aqk avatar Apr 24 '21 06:04 aqk

Hello - thanks for your fix. We do want to move to C++ stdlib calls, but have had to move slowly because of the number of platforms we support.

@wjblanke will this work on the oldest macos we currently support?

I think the question is whether Gulrak supports it. If it is compiling on MacOS should be OK

wjblanke avatar May 24 '21 21:05 wjblanke

Also note there is an update to Gulrak - https://github.com/Chia-Network/chiapos/pull/259

hoffmang9 avatar May 24 '21 22:05 hoffmang9

'This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed.'

github-actions[bot] avatar Aug 12 '21 11:08 github-actions[bot]