Johan Appelgren

Was looking at #716 and couldn't reproduce the issue using an SQLite db. I'm not sure, but I think the EF SQLite implementation does not update the specified rowVersion column...

net45 assembly missing from Antlr4.Runtime.Standard 4.10.1 nuget package

3

This causes build errors in our projects that target .NET 4.6.2. Looking at https://github.com/antlr/antlr4/blob/master/runtime/CSharp/src/Antlr4.csproj it looks like a net45 target is built and included as long as you build on...

Not possible to Substitute.For(new[] { typeof(ISomething) }, null) in 4.3.0

4

https://github.com/nsubstitute/NSubstitute/blob/f890efaeb7cebe01aa6304422fd2936dcfefe290/src/NSubstitute/Proxies/CastleDynamicProxy/CastleDynamicProxyFactory.cs#L167 It was changed from: ```csharp private static bool HasItems(T[]? array) { return array != null && array.Length > 0; } ``` to ```csharp private static bool HasItems(T[]? array) =>...

Tests with some characters in the name do not work very well

2

* NUnit and NUnit3TestAdapter versions `` `` * Visual Studio edition and full version number (see Help About) Microsoft Visual Studio Professional 2019 Version 16.5.4 * A short repro, preferably...

Exception is thrown if method with an interpolated string handler argument on a mocked interface is called

2

**Describe the bug** If a mocked interface has a method with an interpolated string handler an exception is thrown if the method is called. **To Reproduce** ```csharp using System.Runtime.CompilerServices; var...

Add support for old Excel XML format

4

Seems to be documented here: https://msdn.microsoft.com/en-us/library/aa140066(office.10).aspx.

Not strictly an Excel file but in a way it makes sense to support them since they can be opened by Excel.

Something to look into in the future.

Date format 55 not detected as a date in .xls file

7

Looks like we're missing some built-in formats. 0-163 are reserved for built-in formats but we only have up to 49. 55 looks to be a date when saving with Excel...

Depth probably shouldn't be misused to return the current row index

3

https://github.com/ExcelDataReader/ExcelDataReader/blob/f2abb75d3b3063e97db9579723b798ef30f50ca7/src/ExcelDataReader/ExcelDataReader.cs#L37 The IDataReader.Depth property should return the depth of nesting for the current row which, I think, is not the same as row index. https://docs.microsoft.com/en-us/dotnet/api/system.data.idatareader.depth?view=netframework-4.8 Would be a breaking change...