Florian Apolloner

Found your test issue. Please rebase against `main` and then you will need to get rid of the remaining `self.unique_identifier` that got introduced in the meantime.

@felixfontein _ConsulModule was documented as private for exactly that reason to allow for changes like these early own. On Sun, Mar 24, 2024, at 22:41, Felix Fontein wrote: > ***@***.****...

My available time is still rather limited, I can try a thorough review next week. What I could spot while scrolling over it on the phone: * https://local-host.de/morestatus we shouldn't...

> For the idempotency tests for checks, the object we get from Consul differs from the module params. What exactly differs? I have handled this in other modules as well....

Alright, I missed those. Then you will at least have to update the module documentation to update the expectations for diff and check mode. In the meantime I have asked...

Didn't change my mind On Fri, Jun 14, 2024, at 21:22, Felix Fontein wrote: > Beside the above, I think this looks good (assuming that @apollo13 > didn't change their...

I think this fix just breaks stuff in the other direction. Now `SCRIPT_NAME` won't get applied in threads if I am reading it correctly. As I wrote on the ticket...

With the existing behavior the setting is cached once it is accessed from the main thread and then also available in background threads without a request context -- or am...

Yes, accessing `STATIC_URL` to early (kinda before a request arrives) will break it -- and we should see about fixing that. That said, settings in Django are supposed to be...

> However, `STATIC_URL` is already an exception in the codebase. The existence of `LazySettings._add_script_prefix` proves that this setting was intended to be dynamic and aware of the script prefix That...