Florian Apolloner

Results 361 comments of Florian Apolloner

> Although I haven't written many CNI plugins myself (a couple), I also would prefer separate args instead of a JSON blob, and I think following the same convention as...

Pushed a commit with env variables. Are there any others we should add? Task imo makes no sense since the networking information is shared by all tasks in a group.

> Job IDs (and group labels) can have ; in them, which would break the [CNI_ARGS spec](https://github.com/containernetworking/cni/blob/main/SPEC.md#parameters). This is a valid job! Sigh, and according to the spec there seems...

And what is the plugin supposed to do then? Throw it's hands up in the air or just panic and not assign an IP to the container :dagger: Joking aside,...

Works for me, just wanted to be sure that this really what we want. That said, I personally don't have any use for jobnames containing a semicolon and would probably...

Works for me yeah, should be able to implement it as well. No promises on the time-frame though since I am swamped with other work currently and don't want to...

@gulducat Found some time after all (weekends and such ;)). Feel free to adjust the PR as needed, especially if it is less work than playing back & forth with...

Your changes look good imo, I especially like that we don't have duplicate the env names now.

title & description update, let me know if anything else is missing.

Hi Daniel, Thank you for your answer. Are there any details available somewhere about this new architecture (most importantly will this new architecture still support raw html/css or will it...