Florian Apolloner

Results 185 comments of Florian Apolloner

Okay, now you confused me @bcoca -- when I tested this today the branch was still on https://github.com/ansible/ansible/commit/ce7ea781241b895397ec313d2c016d57b2d7ef6e and it didn't have the `template` option, could that be or am...

I have tested the PR against the hashi_vault collection by adding a few "template" options and it fixes my issues that I have :)

This might be a stupid question, but what would the `restricted` option offer? Why would we want to disable lookups? And I would love for `template` to be the default...

Lovely, thank you for picking up my work.

Fwiw, while it is nice if the test suite runs with a pool enabled I don't think it is a requirement to get this merged. The test suite is rather...

Ah that is because the connection isn't closed on `close` but only returned to the pool. I guess we really have to set `self.connection` to `None` afterwards since we no...

So, I had some time and managed to get the testsuite passing with pooling enabled. During that I discovered one bug in the implementation that we should discuss (see below)....

Btw we should probably create a new ticket for this so we have something to mark as "ready to review"? :D

No, we don't give any ETAs since we are doing this in our free time. If you want to get this in faster, please test it and review the code....

As far as I know Django doesn't support `gevent` officially. So no, this is not something I would consider, I have no idea how `gevent` works. That said if the...