Vince Broz comments

Results 141 comments of


                                            Vince Broz

Using solargraph, can popup documentation for Psych.safe_load, but not for Psych.safe_dump

> Why does solargraph act as if safe_dump does not exist? Looks like Ruby's RBS types don't include that method :( https://github.com/ruby/rbs/blob/36e53a2a75f90356d2410c522da31a4171a8fbbe/stdlib/psych/0/psych.rbs#L46 We don't currently parse Ruby core/stdlib source, just...

Using solargraph, can popup documentation for Psych.safe_load, but not for Psych.safe_dump

That'd fix it for sure. `rbs` is a gem from this GitHub repo: https://github.com/ruby/rbs/blob/master/docs/CONTRIBUTING.md

Fix "Not enough arguments to" false positives on kwarg type checking

Just let me know if you'd like any changes or additional tests, @castwide

Fix "Not enough arguments to" false positives on kwarg type checking

Happy to also send some (smaller) fixes for some other common issues I see with codebases, @castwide?

Support writers in Rails models

Hi @iftheshoefritz - anything you'd like me to do on this PR?

Correctly parse Array<T, nil> and friends

Looks like this fix broke the Hash{T => T} case - will take another crack at things tomorrow.

Correctly parse Array<T, nil> and friends

Superceded by #187

Run specs from plugin projects configured against current code

Hi @lekemula! I almost broke compatibility with solargraph-rspec in #890 :(. I'd like to set CI up here to ensure that solargraph-rspec specs run when configured against the solargraph code...

Run specs from plugin projects configured against current code

Thank you for your kind words! Could you try `bundle exec solargraph clear` and see if it still happens? I've been breaking compatibility with the solargraph cached pins between PRs,...

Run specs from plugin projects configured against current code

I commented out the solargraph-rspec specs for now until they pass against solargraph's master branch - but all of the machinery should be there and ready to go.