Vince Broz

Results 141 comments of Vince Broz

This is ready to go. I haven't gotten solargraph-rspec working yet, but I can do that in a follow-up PR once I have a chance to dig in on it.

Not sure if I want this merged in (it does clutter up code), but I find myself reinventing many of these log statements over and over while figuring out type...

Perf wise, the slowdown from the statements seems in the noise - typed-level typechecking of solargraph's code takes 23-26 seconds of wall clock on my machine either way.

Realistically, there's enough `return if foo.nil?` code out there that this will probably have to wait until we have flow-sensitive typing. If that end up being difficult, I may propose...

This is going to be needed to modernize solargraph-rails to use the RBS collection types, as well as to include shims needed to typecheck solargraph at strict level. I have...

This is another significant chunk out of #1006. There's a bit of overlap with #1062 and https://github.com/castwide/solargraph/pull/1061 where necessary, but it should be straightforward enough to resolve any conflicts after...

Do you happen to know if this is a problem with the current version of Solargraph? You'll need to update Ruby to use it.

Makes sense to me! I like that your PR defaults to current behavior of using the running Ruby version, and agreed that being sneakier looking at .ruby-version et al in...

One thing you might consider as a follow-up (forgive me if you've already mentioned this as a direction) - you'll see newly added stdlib and core methods, as the RBS...

Yep! Using the old info to determine what methods exist, and trimming down the rbs collection information based on it sounds perfect. We used to pull RDoc for core and...