Vince Broz
Vince Broz
> Are they using different levels of typechecking? Or a different Ruby/rbs version, maybe? Yep! The overcommit uses the strong level for the bits you change, the rest is done...
The errors you're seeing at strong level in overcommit will be fixed in https://github.com/castwide/solargraph/pull/1059 - you can either merge that branch in or just ignore the errors entirely.
This works: ``` # @type [Hash{Integer => Foo}] ``` The [YARD docs](https://www.rubydoc.info/gems/yard/file/docs/Tags.md) describe common conventions as: > Hashes can be specified either via the parametrized type discussed above, in the...
(out of the scope of this issue, but I'd like to have solargraph probe the types from literal hashes as well so that you could avoid explicit annotations)
> Not demanding this but I'm genuinely curious, how possible would it be for Solargraph to determine the type of a hash based on what is inserted? Ah, sorry, my...
Thanks for the report regardless--give the latest gem a shot and keep 'em coming!
It broke because overcommit is an automated tool that relies on the formatting of our messages already - see https://github.com/sds/overcommit/blob/main/lib/overcommit/hook/pre_commit/solargraph.rb Maybe we can act like rubocop, make this a command...
> Thanks for the hint - I wonder, though, how much it makes sense to keep both formats when essentially they differ only by a single character. I think the...
Saw it again: ``` [WARN] Error processing request: [NoMethodError] undefined method '+' for nil [WARN] /Users/broz/src/solargraph/lib/solargraph/parser/parser_gem/class_methods.rb:62:in 'block in Solargraph::Parser::ParserGem::ClassMethods#references' /Users/broz/src/solargraph/lib/solargraph/parser/parser_gem/class_methods.rb:68:in 'block in Solargraph::Parser::ParserGem::ClassMethods#references' /Users/broz/src/solargraph/lib/solargraph/parser/parser_gem/class_methods.rb:64:in 'Array#map' /Users/broz/src/solargraph/lib/solargraph/parser/parser_gem/class_methods.rb:64:in 'Solargraph::Parser::ParserGem::ClassMethods#references' /Users/broz/src/solargraph/lib/solargraph/source.rb:183:in 'Solargraph::Source#references' /Users/broz/src/solargraph/lib/solargraph/source_map.rb:138:in...
Down to 45 problems! The PRs above should knock those out.