Antonio Vazquez

Results 146 comments of Antonio Vazquez

What is the status on this PR?

From what I've seen in the repo used for 3d models generation there is a lot of duplicated code. If this is not a critical time task I would try...

https://github.com/particle-iot/particle-cli/pull/605

It is nice to see this reorganization. I think it helps clarify the structure of the repo. All points made by @evanshultz seem to have been addressed but if anything...

It has been a while since I last had a look at this. To make things easier I have added comments to code to make it easier for the reviewer....

See https://github.com/bincrafters/community/issues/781

See https://github.com/bincrafters/community/issues/1054

I understand your position. Maybe going to that level of detail is not a good way to proceed. In any case, there has been a history of non-agreement about the...

Currently two different styles coexist in the library. Please, @poeschlr pick the one you like the most: One liner: ![screenshot from 2018-11-08 11-11-52](https://user-images.githubusercontent.com/304193/48192097-2653a800-e347-11e8-8cd7-d7f4bc9162be.png) Two lines: ![screenshot from 2018-11-08 11-08-13](https://user-images.githubusercontent.com/304193/48192043-04f2bc00-e347-11e8-9808-97c64e5b0c6b.png) Thank...

Data from https://github.com/KiCad/kicad-symbols/issues/429#issuecomment-436943325 There are more symbols with a single line. Thanks