kicad-footprint-generator icon indicating copy to clipboard operation
kicad-footprint-generator copied to clipboard

Published 20 hours ago • verified publisher icon pointhi

Capacitor_THT: Update and regenerate models

Open antoniovazquezblanco opened this issue 4 years ago • 2 comments

Update scripts to allow to generate capacitors withouth splitting the lib. An atempt on continuing https://github.com/KiCad/kicad-footprints/pull/1715

antoniovazquezblanco avatar Feb 27 '20 11:02 antoniovazquezblanco

Code Climate has analyzed commit a19ec74d and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot] avatar Feb 27 '20 11:02 codeclimate[bot]

It has been a while since I last had a look at this. To make things easier I have added comments to code to make it easier for the reviewer. Summary of the changes:

  • Avoid using ${KISYS3DMOD} in library name in the top level script. Underlying generator script will add this to corresponding places instead.
  • Avoid capacitor splitting by libraries yet (Someone had introduced this into the scripts but the models were not updated and changes have been refused so I fixed this situation by reversing those changes). It will probably be done in the future but planning is required.
  • Check that the output folders exist before writing the footprint files to avoid errors.

antoniovazquezblanco avatar Apr 30 '20 17:04 antoniovazquezblanco