Anton Ryzhov

Results 12 comments of Anton Ryzhov

I'm +1 to this ticket. I agree that throwing exceptions to eventloop is pretty ugly. I've looked through yours suggestions about interface, and I have something to offer too. 1....

@benjamin-hodgson > The error_callback proposal works best when the two functions are unrelated. Which of these two use-cases is the more common? I's pretty common usecase — callback handles messages,...

@TarasLevelUp I'm +1 for `asyncio` callback-less style, raising better than bunch of callbacks.

@benjamin-hodgson > `ConsumerAdapter` should be provided as part of the library… the message callback and the error callback… putting them in a class seems natural. Am I right, I (library...

> What are the consequences of forgetting to use a `try/finally` It doesn't make worse current callback implementation, there is much more simpler to forget about cancellation.

I'm +1 for fifth proposal. I didn't get what `CancellationToken` is and why it should return 2 objects. I remind you that throwing exceptions inside `connection_lost` is ugly. I expect...

Are you going to merge this?

@the-knights-who-say-ni Got "Contributor Form Received"

@1st1 In case you haven't received notification about last push, I'm notifying about this by the comment.