Anthony Fu

Results 1225 comments of Anthony Fu

I personally would consider this a bit out-of-scope. /cc @pi0 do you think this could have a valid use case using bookable?

One way I think could be more generic is that we implement the Rollups' `api` props that basically allowing arbitrary objects to pass in, and let plugins define the interface...

If there was no map from the beginning and we provide a map, it will cause Webpack to throw an error on merging the sourcemap with null

I would need a reproduction to confirm this is a valid fix.

Weird, I will investigate

Wonder if we could have a mechanism to remove the inline style once the external one takeover or navigate to another page?

Can't we await Vite 3.1 for the object hook? I am still not a fan of having integration-specific logic built in.

I am actually fine with this PR since it doesn't add extra complexity. @chu121su12 What's your opinion on that? Do you mean you prefer a more general solution?