vite-plugin-pwa icon indicating copy to clipboard operation
vite-plugin-pwa copied to clipboard

feat: add VitePress integration

Open userquin opened this issue 3 years ago • 3 comments

I need to change the docs

closes #355

userquin avatar Aug 17 '22 12:08 userquin

Deploy Preview for vite-plugin-pwa ready!

Name Link
Latest commit fa2f1567cfc25eb8636c8dab55ae4c5dd52279a1
Latest deploy log https://app.netlify.com/sites/vite-plugin-pwa/deploys/630686cd12a5520008b1f4dc
Deploy Preview https://deploy-preview-356--vite-plugin-pwa.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 17 '22 12:08 netlify[bot]

Can't we await Vite 3.1 for the object hook? I am still not a fan of having integration-specific logic built in.

antfu avatar Aug 25 '22 06:08 antfu

Can't we await Vite 3.1 for the object hook? I am still not a fan of having integration-specific logic built in.

We need to do this way for SvelteKit and VitePress, both repos reject the integration.

For VitePress there is no race condition we only need to use the build end hook

For SvelteKit we need both, the integration and the sequential hook.

An alternative can be split the repo similar to UnoCSS with separate integrations.

userquin avatar Aug 25 '22 08:08 userquin

included in the integration repo

userquin avatar Oct 03 '22 16:10 userquin