Anthony Fu
Anthony Fu
你俩商量一下看要用谁的吧 😂
从整体上看我觉得 @webfansplz 的实现更加契合 VueUse 的设计一些，@okxiaoliang4 你可以把你的应用场景分享出来，你们讨论看看怎么样可以找个能满足双方需求的实现。 我只大概扫了一下代码，等你们讨论完我再 review，这里是一些建议： - `CountDown` -> `Countdown` 这个是一个词 - 函数名称改叫 `useDateCountdown` 比较好一些，以免和秒数倒计时的概念混淆 - 内置耦合的 format 我认为有违组合的理念，可以提出来一个 `useDateForamt` 复用
Can we have some tests for it? Thanks
The current approach has a downside in that if you want to update the list for the cycle dynamically the index will break. I am more leaning toward having the...
Can you also initiate some tests for it? Thanks.
I am not very sure about this as this adds quite some weight to the function - I would suggest to implement it on the user land, or as a...
I think we'd better use `undefined` than `0`
I am not sure about this. It seems a bit too verbose to me. We might need a cleaner abstraction.
I think we should make it return as refs object in the next major version. The current approach of wrapping `reactive` with `ref` is not ideal to me.