Anthony Fu

Results 1222 comments of Anthony Fu

Emm, we are already using it. Did you tested out? I current don't have bandwidth to submit for store yet tho.

Sounds interesting, do you mind drafting a PR for the functionalities in your mind? Thanks.

Could do, but I am mostly concerned about that if Chrome Store allows that 🤔

The problem here is the extension permission, which need to be included in the manifest statically, while have **/* could make the reviewing much harder.

I see there might be a solution here: - https://github.com/sindresorhus/refined-github/blob/32abfaaa4696053fa956f12b0186339e80f19292/distribution/manifest.json#L25-L27 - https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/optional_permissions - https://github.com/sindresorhus/refined-github/issues/3543 ![image](https://user-images.githubusercontent.com/11247099/133213722-9b205103-d640-44e3-b68d-372f334eb0bd.png) While I don't have access to a GitHub Enterprise instance, I will need to leave...

I am not very sure why but as a workaround, you can do this and it will work the same: ```vue import Iconify from '@iconify/iconify' import '@purge-icons/generated' ```

Iconify has a runtime that replaces the DOM with `[data-icon]` and I guess that's the reason the VDom is mismatched with the real ones. I am not very familiar with...

@JessicaSachs it's kinda a limitation of how Iconify runtime implemented https://github.com/antfu/purge-icons/issues/17#issuecomment-815498834 you can try to adapt to this component: https://github.com/antfu/antfu.me/blob/master/src/components/Icon.vue

For the record, I made `markdown-it-shiki` using the similar approach of rendering twice: https://github.com/antfu/markdown-it-shiki#dark-mode