github-doorcat icon indicating copy to clipboard operation
github-doorcat copied to clipboard

Firefox (and standard) support

Open mathieutu opened this issue 4 years ago • 3 comments

Thanks for this extension, it seems really cool!

However, as usual, Google doesn't respect standards, and Chrome doesn't comply with W3 Browser Extensions WebExtension/BrowserExt API.

But Mozilla have made some tools to facilite the compat work. https://github.com/mozilla/webextension-polyfill

No bandwith right now but if someone wants to give a try...

mathieutu avatar Sep 09 '21 23:09 mathieutu

Emm, we are already using it. Did you tested out? I current don't have bandwidth to submit for store yet tho.

antfu avatar Sep 10 '21 03:09 antfu

🤦‍♂️ Oh sorry! I've seend that at 1am, and actually even haven't tested it. I basically thought that you made it only for Chrome.

I'm trying to test it, and have an error. Screenshot 2021-09-10 at 08 40 44

I've done a yarn build and yarn pack:firefox

Btw, do you want a PR to create automatically a release with the files for each tag? It'll let people download it without the the need for store in a first time.

mathieutu avatar Sep 10 '21 06:09 mathieutu

Hey @mathieutu, I just got this addon to load by loading it as a temporary addon from Debug Add-ons menu. (about:debugging#/runtime/this-firefox)

I wonder if an ID needs to be added for it to work, see this SO post.

Coteh avatar Sep 16 '21 20:09 Coteh