Magdalena Kowalczuk
Magdalena Kowalczuk
Thanks! I'll also repeat my question: **what would be a more elegant example - applying them on ndrrays or a dataframe?** I noticed that some examples in sklego are based...
Coolio! That's more of an idea for the future, but when all examples are added, maybe it would be good to base them all on arrays then. Just sayin'
 Wondering what happend here
Oh gee, there are even more failed tests now.😮 About examples I copied the approach with the arrays from scikit-learn docs on PCA (check ss)  and I tinkered around...
Sure, I'll do it the way it's done in the test suite.
> Yep the doc page is using iris dataset, which I would not expect to have any particular outlier. We have one [obvious example](https://github.com/koaning/scikit-lego/blob/main/tests/test_estimators/test_umap_reconstruction.py#L42) in the test suite. > Hey...
I'm on that, just sayin
If it wasn't already benchmarked and implemeted I'd like to take it
I'll take `Expr.__sub__`