scikit-lego icon indicating copy to clipboard operation
scikit-lego copied to clipboard

`decomposition.umap_reconstruction.UMAPOutlierDetection`

Open FBruzzesi opened this issue 1 year ago • 4 comments

FBruzzesi avatar Apr 26 '24 20:04 FBruzzesi

@anopsy created separate issues to link directly PRs

FBruzzesi avatar Apr 26 '24 21:04 FBruzzesi

Thanks! I'll also repeat my question:

what would be a more elegant example - applying them on ndrrays or a dataframe?

I noticed that some examples in sklego are based on dataframes and some on numpy arrays or ndarrays. I noticed that scikit-learn mostly uses arrays in their examples. Let me know what do you think, maybe I'm overthinking that

anopsy avatar Apr 27 '24 06:04 anopsy

I would suggest to use arrays as well wherever possible. Dataframes may be more interpretable but they are more in the direction of skrub philosophy

FBruzzesi avatar Apr 27 '24 08:04 FBruzzesi

Coolio! That's more of an idea for the future, but when all examples are added, maybe it would be good to base them all on arrays then. Just sayin'

anopsy avatar Apr 27 '24 08:04 anopsy

Closed by #654

FBruzzesi avatar Jul 20 '24 09:07 FBruzzesi