Andrew Walker
Andrew Walker
What about locked users or ones with password disabled? Is there a particular reason you aren't using libpam for this? We already have pam modules for winbind and ldap. Then...
``` [2022/09/29 08:43:02] (ERROR) middlewared.call_hook():1146 - Failed to run hook core.on_connect:(*(), **{'app': }) Traceback (most recent call last): File "/usr/local/lib/python3.9/dist-packages/middlewared/main.py", line 1139, in call_hook await fut File "/usr/local/lib/python3.9/dist-packages/middlewared/main.py", line 1172,...
Currently fails in jenkins, will revisit later.
Noticed while looking at some async path validator code.
> Sorry, but it looks so messy now... I don't see why these methods should be asynchronous in the first place, can we just make them entirely synchronous? Yeah, that's...
Will run through jenkins tests tomorrow. This currently depends on `pool.dataset.mountpoint` endpoint which is being added in a separate PR by Vlad.
> @anodos325 can you rebase this please before we review? Hmm... we should have coordinated sysdataset changes while this was pending.
@themylogin ready for review
Are there any tests that need to be updated?
Don't change the schema for `ldap` and `activedirectory`. These are clustered, but your other configuration options are node specific. Maybe make it a system setting.