middleware icon indicating copy to clipboard operation
middleware copied to clipboard
verified publisher icon truenas

NAS-116495 / 22.12 / convert most of sysdataset plugin to sync

Open anodos325 opened this issue 3 years ago • 7 comments

There were quite a few IO calls being made outside of threads.

anodos325 avatar May 31 '22 18:05 anodos325

Jira URL: https://jira.ixsystems.com/browse/NAS-116495

bugclerk avatar May 31 '22 18:05 bugclerk

Noticed while looking at some async path validator code.

anodos325 avatar May 31 '22 18:05 anodos325

Sorry, but it looks so messy now... I don't see why these methods should be asynchronous in the first place, can we just make them entirely synchronous?

Yeah, that's fair. I'll make them synchronous.

anodos325 avatar Jun 02 '22 14:06 anodos325

Will run through jenkins tests tomorrow. This currently depends on pool.dataset.mountpoint endpoint which is being added in a separate PR by Vlad.

anodos325 avatar Jun 23 '22 21:06 anodos325

@anodos325 can you rebase this please before we review?

themylogin avatar Jul 13 '22 12:07 themylogin

@anodos325 can you rebase this please before we review?

Hmm... we should have coordinated sysdataset changes while this was pending.

anodos325 avatar Jul 14 '22 14:07 anodos325

@themylogin ready for review

anodos325 avatar Jul 14 '22 18:07 anodos325

No unexpected regressions with integration tests on non-HA or HA systems. HA failover is still functional with these changes. I'm merging.

yocalebo avatar Sep 23 '22 17:09 yocalebo