Andrew Morgan

ephemeral_public_keys table grows indefinitely

1

The `ephemeral_public_keys` table gains a new row whenever a 3pid invite (via email) is sent. The token is sent as part of the email and is validated upon clicking the...

POST /_matrix/identity/api/v1/validate/email/requestToken returns "success" key

2

`POST /_matrix/identity/api/v1/validate/email/requestToken` returns a `success` key, which is not defined [in the spec](https://matrix.org/docs/spec/identity_service/unstable#post-matrix-identity-api-v1-validate-email-requesttoken). ``` { "success": true, "sid": "702675865" } ```

Add tests for unbinding addresses

2

https://github.com/matrix-org/sydent/issues/398 seem to indicate that neither Sydent itself nor [matrix-is-tester](https://github.com/matrix-org/matrix-is-tester/) seem to have tests for [POST /_matrix/identity/v2/3pid/unbind](https://spec.matrix.org/unstable/identity-service-api/#post_matrixidentityv23pidunbind). It would be good to get some so that similar issues can be...

When sending the following request: ``` POST /_matrix/identity/api/v1/validate/email/requestToken { "client_secret": "bla", "email": "[email protected]", "send_attempt": 4, "next_link": "whatever.com" } ``` I end up with: localhost:8090/_matrix/identity/api/v1/validate/email/submitToken?token=iYstSvVkJsWJzCyflAv1DERuvvZRZgfq&client_secret=bla&sid=1648700459&nextLink=blaaaxa.com%3Fsid%3D1648700459 in my email. Note the duplicated...

https://docs.python.org/2/library/sqlite3.html#using-the-connection-as-a-context-manager This allows us to wrap queries in a block: ``` try: with con: con.execute("insert into person(firstname) values (?)", ("Joe",)) except sqlite3.IntegrityError: print "couldn't add Joe twice" ``` that will...

Two things: - [ ] Sydent shouldn't accept a `next_link` parameter for submit token. It should be defined during `/requestToken` and then referenced during the call to `/submitToken` - [...

https://github.com/matrix-org/sydent/pull/184 added a `lookup_hash` field to `local_threepid_associations` but this isn't actually needed. Remove it in a new migration step and make sure 3PIDs are just hashed upon local and global...

`/lookup` doesn't seem to work while `/bulk_lookup` does. `/lookup` pulls an `sgAssoc` from the DB while `/bulk_lookup` just pulls an MXID associated with a address. An sgAssoc looks like the...

Email templates need fixing

1

- [ ] Not all email template values are in the default config (part of #101) - [ ] `email.email.template` and `email.email.invite_template` config values seem to be the same thing?

We switched a long while ago from Google Cloud Messaging (GCM) to Firebase Cloud Messaging (FCM). GCM [essentially became FCM](https://developers.google.com/cloud-messaging/android/android-migrate-fcm). Thus APNs, **FCM** and WebPush are the only push backends...