Ankush Menat

``` TypeError: frappe.template.compile(...) is not a function at frappe.render (microtemplate.js:100:42) at frappe.render_template (microtemplate.js:114:16) at FormTimeline.get_comment_timeline_content (form_timeline.js:289:36) at FormTimeline.get_comment_timeline_item (form_timeline.js:283:18) at form_timeline.js:270:40 at Array.forEach () at FormTimeline.get_comment_timeline_contents (form_timeline.js:269:34) at FormTimeline.prepare_timeline_contents (form_timeline.js:159:36)...

 test failing since yesterday, no good.

@mergifyio backport version-14-hotfix

@rmehta we were discusing what to do with this. At present, I am not sure about what major changes that need to happen besides converting it to doctype... just doing...

`iframe`s aren't a good way to achieve this! It will be very limiting in the future as it's literally a separate web page embedded inside another page. 😄 This can...

@1ubuntuuser Semantic commits failed - it's fine we can squash the whole PR. Linters - you'll have to fix this. Run pre-commit on files so it'll auto format them. Follow...

You need to user `before_update_after_submit` or `on_update_after_submit` https://frappeframework.com/docs/v14/user/en/basics/doctypes/controllers#controller-hooks

@Abhirup-99 can you first share what breaks if this isn't done?

@Abhirup-99 that doesn't help me understand WHY this breaks? can you share traceback or something or at least describe what breaks?

This is probably a deeper bug. We by default strip 0 values from JSON files, so adding it won't help much. Not sure why meta is not properly initialized here.