Ankush Menat

Results 243 comments of Ankush Menat

@justinmk Inbuilt documentation for LSP points to old url of lsp config repo: https://github.com/neovim/nvim-lsp while github usually redirects renamed repositories it would good idea to update documentation to point to...

related UI test failing

Removed requirement. Dropped it from mergify config too. - [x] Python - flake8 config is good enough and can be improved... no need for sider - [ ] JS/others -...

This is sorta expected after we tweaked the algorithm to support acronyms: https://github.com/frappe/frappe/pull/16478 Still doesn't feel natural to not show literally 100% textual match first. Anything possible here @ChillarAnand?

It would be better to store normalized UTC timestamp instead? that's what most applications I know do 😅 The usual reason for timestamp over epoch is readability, it has no...

We can modify the scheduler's timezone to some other configured value if that's only roadblocker. It's a very localized changed in `scheduler.py` It's better to keep scheduler in local timezone...

Okay, maybe this shouldn't be part of migration, only install. Reason: during migration we don't want to replace user's preference with newly added defaults.

Do you mean an event when the form first becomes dirty? https://github.com/frappe/frappe/blob/9a03c535725ea066af5cd4b4f6316d01868876d1/frappe/public/js/frappe/form/form.js#L1237

@rtdany10 the one that I linked before doesn't work? Or do you need one-time trigger only? When form first becomes dirty. In that case you'll have to check for `__unsaved`...

offtopic but kinda on topic: if you know any specific topics that need focused work on improving docs then drop a comment here: https://github.com/frappe/frappe/issues/17750 e.g. "I can't figure out how...