Ankush Menat

Yeah just that change + UI test fixes can be enough. Some kind of throttling is helpful but not really necessary.

@iamejaaz

In general to er on side of caution rollbacks are not done silently. We can prompt for rolling back broken site like we do for broken bench.

Here are some numbers from fresh install of Frappe + ERPNext. 1. Compressed backup size: **1.5MB** (takes about 2-3 seconds to complete) 2. Average actual disk usage of each empty...

Basic requirements: - learn how to write semgrep rules - https://semgrep.dev/docs/writing-rules/overview/ - Ensure minimal false positives (scan existing codebases) - Write test cases for test cases! https://semgrep.dev/docs/writing-rules/testing-rules/

https://erpnext.com/ is full-fledged ERP that you're looking for. Frappe Books was not designed for online use like this.

Assignment rule is similar. Really want some kind of UI for composing multiple filter groups with `and`/`or`. Ideas for future projects - @sokumon @iamejaaz :eyes:

@iamejaaz can you get this merged please. Very important feature from "low code" POV. Also needs to be used in other places. (assignment rule, SLA etc)

If the change isn't detected then how will user update filters? (just filters, without fake dirtying rest of the form)

@barredterra it most likely is on purpose to avoid triggering list view refresh with incomplete filter data (?) Though we do check for incomplete filters and remove them. It might...