Ankush Menat
Ankush Menat
FYI https://github.com/frappe/frappe/issues/25542 Also this isn't `chore`, it's potentially breaking fix so use `fix!`
- [ ] review all `if ... == "postgres"` code blocks in ORM (query builder) to remove bad fixes like `order_by = ""`
Renaming happens from background since v14. This allows larger rename to happen which weren't possible before.
> if a user has the Share permission, they should be able to see with whom the document is shared; otherwise, they shouldn’t. Doesn't quite fit in the permission model....
We usually close issues when fixes are merged. FYI @AarDG10
Refer - https://github.com/frappe/frappe/pull/24365 - https://github.com/frappe/frappe/issues/18826 - https://github.com/frappe/frappe/pull/19810
@AarDG10 You might need much bigger test data to verify. Item batchsize itself is 10k, so 50K rows won't give a good picture. FYI it might be required to use...
@AarDG10 good unbuffered cursor gives `O(1)` memory usage. Default implementation clearly seems to be `O(n)` aka buffered cursor?
> Seems like it cause we are fetching SQL_ITERATOR_BATCH_SIZE rows, so won't that just make it O(iter_size) theoretically? iter size is a hardcoded constant, so it is still O(1) theoretically...
@AarDG10 update branch and remove conflicts