Francesco Cariaggi
Francesco Cariaggi
Thanks for the reply. Just to clarify, is it a missing feature of the library or is it a limitation of the tokenization algorithm?
Hi, I would be interested in contributing to this. What additional data types are you planning to support exactly?
I haven't added any unit test for the 2 small helper functions I added, though I've modified existing ones in accordance to the changes I made. Not sure what's your...
@BenjaminBossan I've tried addressing your comments, see if it's good now. One minor detail: I renamed the function `_is_iterable_of_strings` to `_is_sequence_of_strings` because now I'm not expecting generic iterables anymore as...
> @anferico are you still working on this? I am, it's just that I haven't had much free time recently. I'm happy to continue working on this, but if it's...
@BenjaminBossan I think I've addressed all the points above, however now I'm facing another problem. I noticed that when calling the `test_get_column_names_pandas_not_installed` function, I incur into a weird recursion error....
@BenjaminBossan thanks, the recursion error just got fixed. I also fixed the `changes.rst` file. A couple of comments regarding my latest commit: - I removed support for generators as valid...
@BenjaminBossan I've addressed the latest comments, let me know if this can be merged.
Done, thanks again for your support!
@kcq Thanks for your reply 👍 I didn't understand whether it's possible to obtain an optimized Dockerfile or not though. Did I miss some important flags in the commands I...