skops icon indicating copy to clipboard operation
skops copied to clipboard

Support more array-like and list-like string-like data

Open adrinjalali opened this issue 2 years ago • 2 comments

https://github.com/skops-dev/skops/pull/45 introduces adding sample data to the config.json, but it only accepts ndarray/dataframe for arrays and a list of strings for text tasks.

We should support more data types, and convert them to what we can understand.

xref: https://github.com/skops-dev/skops/pull/45/files#r933221139

adrinjalali avatar Jul 29 '22 15:07 adrinjalali

Hi, I would be interested in contributing to this. What additional data types are you planning to support exactly?

anferico avatar Oct 07 '22 21:10 anferico

See the comment linked above. So for example for text classification and text regression, we currently only allow lists of str, but scikit-learn is more flexible there, allowing, for instance, numpy arrays of strings, or iterables in general (that may not support indexing).

BenjaminBossan avatar Oct 10 '22 08:10 BenjaminBossan

We have something better now. Closing this and we can open specific issues once they occur.

adrinjalali avatar Jan 24 '23 16:01 adrinjalali