Aneeque Ahmad
Aneeque Ahmad
@listiani13 I have opened another similar PR. Thanks for allowing https://github.com/react-navigation/react-navigation/pull/10558 cc: @satya164
@satya164 , if I understand correctly, wouldn't pushing new entries on page load be more confusing for the user, as the browser back button will now behave differently than it...
@satya164 yes thats maybe a workaround but IMO we should find perfect resolution to fix this issue. Yes, this issue is important i have filled the form to hire your...
This is reproducible on latest staging and production https://user-images.githubusercontent.com/36359331/196845383-7842c480-7c71-46ca-b3de-a6f3918ca86d.mov
@tjferriss This issue is still reproducible on latest dev built. Please right click on a `comment that is a link`.
### PROPOSAL **Problem:** The type of anchor is defined as `node` but it's a reference to the DOM node. https://github.com/Expensify/App/blob/92eff7267aa7be67463873cdb431f5cd79c22b59/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.js#L20-L22 **Solution** The type of this DOM node should be object...
@aimane-chnaif I think my [proposal](https://github.com/Expensify/App/issues/11903#:~:text=anchor%3A%20PropTypes.object) is working as expected on native platforms. The error you said [above](https://github.com/Expensify/App/issues/11903#:~:text=your%20solution%20in%20this%20proposal%20causes%20regression%20on%20native%20which%20is%20already%20working.) is happening on native platform since it is given the `type number` and...
@aimane-chnaif I'm not sure what you're talking about. Please see the `Actual result` of the reported [bug](https://github.com/Expensify/App/issues/11903#:~:text=Console%20error%3A%20Failed%20prop%20type%3A%20Invalid%20prop%20anchor%20supplied%20to%20BaseReportActionContextMenu%2C%20expected%20a%20ReactNode%20at%20BaseReportActionContextMenu). > this is what anchor is set to This is never set to...
The screenshots/Videos are: ### WEB: ### IOS: @aimane-chnaif You're right what you said [here](https://github.com/Expensify/App/issues/11903#:~:text=your%20solution%20in%20this%20proposal%20causes%20regression%20on%20native%20which%20is%20already%20working.) It was working fine on IOS as the proptype is actually node on IOS (like the...
### UPDATED PROPOSAL: Solution: Need to update the existing code **From:** https://github.com/Expensify/App/blob/34f53dd8020e0224c392e767a910fa7ddee3aee1/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.js#L21-L22 **To:** ``` /** Target node which is the target of ContentMenu */ anchor: PropTypes.oneOfType([PropTypes.node, PropTypes.object]), ``` cc: @aimane-chnaif