[HOLD #11795] [$250] Invite new members to workspace text-input is not focused - Reported by @aneequeahmad

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click on use icon to open setting page.
2. Click on workspace > manage members > invite .

Expected Result:

Search field of invite new members should be focused.

Actual Result:

Search field is not focused

Workaround:

unknown.

Platform:

Where is this issue occurring?

• Web
• Desktop App

Version Number: 1.1.91-0 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43995119/186821068-9b6fcc6f-6ed6-4ff4-84cd-d82045253453.mov

Expensify/Expensify Issue URL: Issue reported by: @aneequeahmad Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661437929132899

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[varshamb]

Proposal

In WorkspaceInvite page autoFocus for OptionsSelector is false. Making it true will fix this issue.

https://github.com/Expensify/App/blob/386c5ad8369a351528a70374dd7b92f1f9ec49cb/src/pages/workspace/WorkspaceInvitePage.js#L249-L250

[neil-marcellini]

Closing this because that's the expected behavior. See my slack comment here. If we agree it's a bug in the future then we can re-open this.

[neil-marcellini]

Re-opening because the Slack discussion is ongoing and there's some good points there.

[neil-marcellini]

I think this would be a good external issue, but we should hold on implementation until we decide what to do in Slack.

[melvin-bot[bot]]

Triggered auto assignment to @zanyrenney (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[zanyrenney]

@neil-marcellini it looks like we landed on doing nothing for now. Please can you confirm your thoughts as you said hold until we decide in slack... Thanks!

[zanyrenney]

oops! didn't mean to close with that comment.

[neil-marcellini]

I don't think we have talked about it anymore since then. I don't see anything from a quick Slack search. We could close this or make it Monthly again.

[mountiny]

Checked in with Zany on this one, it is an old issue and not reproducible in staging/prod anymore so we are good to close it 🎉

[zanyrenney]

Asked Vit to doublecheck on Dev as I don't have access.

[varshamb]

This is still reproducible in staging and prod so I think this should not be closed.

Prod Web

https://user-images.githubusercontent.com/111683206/196844431-3078abf0-10a2-4070-9aeb-f50c3525fe44.mov

Consider my Proposal: https://github.com/Expensify/App/issues/10587#issuecomment-1228632033

cc: @neil-marcellini @zanyrenney

[aneequeahmad]

This is reproducible on latest staging and production

https://user-images.githubusercontent.com/36359331/196845383-7842c480-7c71-46ca-b3de-a6f3918ca86d.mov

[mountiny]

Oh boy, there must have been some confusion here. Reopening and applying an external label

[melvin-bot[bot]]

Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot[bot]]

Current assignee @neil-marcellini is eligible for the External assigner, not assigning anyone new.

[neil-marcellini]

Ok let me summarize the Slack thread a bit. We agree that this is a bug because users should be able to start typing immediately, and users on desktop / web like to do this especially. The problem is that this page looks really bad on mobile devices with a smaller screen height, so we removed the auto focus in this issue. Here's the issue for that.

Here's how it looks on a smaller mobile device

It looks fine on iPhone 13

The conclusion of the thread is that we need to rethink / re-design this page. Let's start that process now @Expensify/design. If we are planning to refactor this page in another issue, then we can hold this issue on it. @JmillsExpensify do you know if we already have plans to redesign the workspace invite page?

[rushatgabhane]

~@mountiny this issue should be closed 😂 https://expensify.slack.com/archives/C01GTK53T8Q/p1661537399863459?thread_ts=1661437929.132899&cid=C01GTK53T8Q~

nvm, there's a comment above

[rushatgabhane]

unassigned by mistake. can someone please re-assign me, thank you!

[melvin-bot[bot]]

📣 @rushatgabhane You have been assigned to this job by @neil-marcellini! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[neil-marcellini]

Hahaha uh oh, no Melvin, @rushatgabhane is C+.

[JmillsExpensify]

@JmillsExpensify do you know if we already have plans to redesign the workspace invite page?

No plans to re-imagine the workspace invite page, though come to think of it, that personal invite message should almost certainly be converted to push-to-page.

[rushatgabhane]

@JmillsExpensify is there a doc / thread explaining push to page? I need help understanding push to page

[mountiny]

Wait there is a planning issue for this 🙈 I did not know this was intentional, lets put this on hold then

[mountiny]

Here is the design issue https://github.com/Expensify/App/issues/11795

[JmillsExpensify]

@rushatgabhane Answering you in the linked [main] issue.

[zanyrenney]

On hold for this still: https://github.com/Expensify/App/issues/11795

[mountiny]

I think we can make such on HOLD issue monthly, the linked issue wont be fixed in a week I assume.

[zanyrenney]

on hold.