Andy Grove

> Indeed, but not one that is currently enabled for this repo smile Ah, I see. We can enable `rebase` easily enough. https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Mergebuttons

I've started reviewing this, but there are many changes and referenced issues I need to go read. I will continue with the review tomorrow.

There is a related PR to add support in the SQL query planner and logical plan, but does not add physical plan support: https://github.com/apache/arrow-datafusion/pull/3405

@avantgardnerio @alamb This is one side-effect of the recent change to generate protobuf into the `src` directory. I don't have a strong opinion on how much of an issue this...

> @andygrove do you have a link to the build in question? The error message isn't sufficient in and of itself, but I feel like this is fixable. https://docs.rs/crate/datafusion-proto/12.0.0

Also happens in common_sub_expression_eliminate: ``` Skipping optimizer rule common_sub_expression_eliminate due to unexpected error: Error during planning: 'Timestamp(Nanosecond, None) + Int64' can't be evaluated because there isn't a common type to...

I think we can close this issue now that there are specific issues filed for optimizer rules that are failing, such as https://github.com/apache/arrow-datafusion/issues/3797, https://github.com/apache/arrow-datafusion/issues/3416, https://github.com/apache/arrow-datafusion/issues/3417, and https://github.com/apache/arrow-datafusion/issues/3418.

@alamb PTAL when you can. LGTM but I have not been working so closely with physical execution lately.

> To get CLion to work you need to run a full build so that the files exist, and then "Refresh Cargo Projects". It then finds the files. I wasn't...

I agree that there will be differences. See the conversation at https://github.com/apache/arrow-datafusion/pull/3407#discussion_r967137788 for one example where we have to work around a difference and this example is possibly due to...