Andy Grove

Results 657 comments of Andy Grove

@xrl @jdye64 @alamb This is now ready for review

> Should the select item `("some_name")[1][20]` be parseable? Right now it's not surviving a round trip. Hi @xrl. I am not sure I understand this. Is the goal to extract...

@alamb Could you review when you have time

> > Is this query working for you in Hive/Trino? > > Yes, array agg then pull out an element. And the query does work on AWS Athena (presto under...

@xrl I filed https://github.com/sqlparser-rs/sqlparser-rs/pull/585 .. let me know what you think

This is partially implemented already by `impl ToString for ASTNode` but this needs to move into the dialect specific code as each dialect will write SQL differently.

> Perhaps we can add a comment somewhere to the code explaining the rationale? @ever0de Would you mind updating this PR to revert the changes but add a comment instead?

> Can I close this PR? Yes, please go ahead! Thanks.

One reason is that I would like to help maintain the package. The proposal is not to bring it back into `arrow-datafusion` but into its own repo `arrow-datafusion-python`. I don't...

> I see -- as I recall your employment situation requires ASF governed projects, correct? It's not quite that simple. There is a process to go through before committing to...