Andy Grove comments

Results 657 comments of


                                            Andy Grove

Implement native version of ColumnarToRow

I am closing this issue for now because I believe that we determined that this is no longer a priority. We can reopen the issue if this changes.

fix: Optimize not to call getNullCount as much as possible

I am now running benchmarks with this PR

fix: Optimize not to call getNullCount as much as possible

I ran my local TPC-DS benchmark and it doesn't show any improvement for that benchmark. ![tpcds_allqueries (4)](https://github.com/user-attachments/assets/99ff1cdc-2b2d-45c6-8859-1347058f127e) @kazuyukitanimura Do you see an improvement with any of the microbenchmark queries?

fix: Optimize not to call getNullCount as much as possible

> Thanks @andygrove hmmm how many iteration was used for your local benchmark? > > I used q27. I will try to run some microbenchmarks to showcase... This was the...

Implement more efficient conversion from Spark column to Comet/Arrow column

I am going to take a first pass at this to see what effort is involved.

feat: Implement to_json for subset of types

@parthchandra could you review?

feat: Implement to_json for subset of types

@eejbyfeldt @Kimahriman you may also be interested in reviewing this one

feat: Implement to_json for subset of types

Thanks for the review @eejbyfeldt! It is really appreciated. Some very good feedback there. I will address the feedback over the next day or two.

feat: Implement to_json for subset of types

@parthchandra @eejbyfeldt This is ready for another review

Implement initial version of to_json

> @andygrove QQ: Upon checking i found out that DataFusion doesn't currently support a built-in `to_json` function. While implementing it directly in Comet is an option, there might be a...