Andy Grove

Results 657 comments of Andy Grove

I'm going to pick this issue up. I am currently studying Spark's code to understand how it works without Comet.

We now have the [Comet Benchmarking Guide](https://datafusion.apache.org/comet/contributor-guide/benchmarking.html) which shows current benchmark results, and all of the TPC-H scripts are open source as part of the new [DataFusion Benchmarks](https://github.com/apache/datafusion-benchmarks) repo, so...

This cast is currently disabled by default, but it would be good to implement this. I have added this to the 0.2.0 milestone.

Thanks @justahuman1! A good place to start is `org.apache.comet.expressions.CometCast#canCastFromLong`. This currently returns false for casting to timestamp, so enabling it here is the first step. Next, you can enable the...

A better test would be something like this: ```scala test("cast LongType to TimestampType") { // input value is interpreted as milliseconds but will be cast to microseconds val min =...

> > the min value here is actually causing an overflow in Spark > > Probably because Spark is converting the value from millis to micros? Right, my understanding was...

@jdye64 @nseekhao fyi

It looks like the logical plan builder should always put the columns in the correct order but this is not happening in some cases .. the fix should probably be...

Here are some observations after reviewing the logical plan code. - `Display` and `Debug` produce similar output. `Display` delegates to `Debug` for most cases. - `create_name` accepts a schema argument,...

@parthchandra Could I get your opinion on the config changes in this PR? I'm not sure this is the best approach but it was previously not possible to have a...