Andraž Jelinčič
Andraž Jelinčič
No worries, I rebased it :)
Thanks for letting me know! Seems the file got corrupted. It was perfectly fine in my local branch, just had to force push it again. On Thu, 25 Jan 2024...
Thanks, yes, I'll take care of that 😊. There are a few more things that need to be modified anyway - I'll do that once Patrick is done with his...
Thanks for these comments, I made the appropriate corrections. > Overall, my impression is that this looks pretty good! It's also really highlighting how we really need a way to...
Also, regarding `langevin.ipynb`: The reason I import private things is that I moved the `LangevinTerm` from `_term.py` into that notebook, just to give you some context on what is coming...
> (let me know when you next want my input on this PR btw) So I made the changes you suggested (except eqxi.scan) on the pr_correction branch. I also made...
Hi Patrick, I made the edits you suggested. In addition I also reformed convergence testing. This includes comparing the values of solutions at several times (not only at t1) as...
@patrick-kidger I haven't managed to address all your comments yet, I'll do the rest tomorrow. But I decided to push it as is so you can have a look at...
Okay, @patrick-kidger I made the rebase and all the necessary fixes now, let me know what you think. Also see my previous comment for some explanation.
> Let's put the SRK example in the devdocs! Will do. > Tests: hmm, okay, I defer to your experience on this! In that case what I'll say is let's...