Andraž Jelinčič

Results 58 comments of Andraž Jelinčič

Quick question @patrick-kidger: Should I make `AbstractFosterLangevinSRK` public and add it under Abstract Solvers in the docs? I haven't done it so far, because, unlike RK and SRK, where the...

So I added the check that drift and diffusion have the same arguments in `AbstractFosterLangevinSRK.init` and also added a short test for this in `test_underdamped_langevin.py`. I will now do the...

I think I now addressed everything you suggested, including the scan trick in both `QUICSORT` and `ShOULD`. I'll do another quick check and then I pass it back to you.

I went through the code and the docs again and now I think I addressed everything you mentioned. Also please take a look at this comment [here](https://github.com/patrick-kidger/diffrax/pull/453#discussion_r1740114406) and let me...

Sorry, I left a tiny problem in the test I added, I fixed it now.

Thanks for bearing with me and taking your time Patrick!! I really appreciate it!

I think they are present in the docs, at the bottom of sde_solvers.md. Maybe you don't build the docs on the dev branch?? To be fair I was very surprised...

No hurry with the `JumpStepWrapper`, I am done with what I needed it for – but of course I am happy to make edits once you review it. And also...

Oh, I see. I don't envy you for having to fix that.

> So I don't think this should ever be an infinite loop -- as the next time around then `prev_dt` (pulled out of the controller state) should be `0.05`, and...