Andrew Walker
Andrew Walker
I think this one is probably best wrapped up after the JOSS manuscript is out. I think the material makes most sense in a documentation section that starts something like:...
Just adding a note here to check links in the various README files before this lands and make sure they point to readthedocs
Also see #163 - we may as well do everything in one go (when I get time to look at this)
## Review checklist for @andreww ### Conflict of interest - [x] I confirm that I have read the [JOSS conflict of interest (COI) policy](https://github.com/openjournals/joss/blob/master/COI.md) and that: I have no COIs...
I've now had a chance to look over and try out the code, and read the manuscript. The manuscript itself looks good and is easy to read. One minor thing...
This is so nearly there. My only outstanding issue is that two of the examples aren't giving me the same output as shown in the documentation. The others all work...
Otherwise everything looks good!
https://github.com/PFPE/shipgrav/issues/18 is fixed for me. @rwegener2: I'm happy to recommend acceptance. @hfmark: Thanks for the constructive engagement.
There isn't, but maybe there should be. @Llannelongue - is the Environmentally Sustainable Computational Science community forum somewhere we could host "CATS users" or similar?
Thanks @Llannelongue - just to check before I dive in - a "structured forum" is just a topic that I can create but a "open unstructured chat" is a channel...