Results 84 comments of Andrew Walker

Ok - that explains what I was seeing. It probably makes most sense to move/copy this repository onto github - ideally as part of https://github.com/geodynamics - and update the remote....

I would be delighted to see a pull request adding this to MSAT. I think it is probably best to have this as a stand alone function modelled on `MS_phasevels`...

Not on master (or in any of the released versions) but @alanfbaird has a pull request (#30) that is almost ready to merge. It could use a test case or...

Yes - this needs to be fixed in the documentation. But, more importantly, I think we need some error checking in the code too. You are supposed to be able...

And we need the same length checks for the elasticity matrix input case.

Should also check the volume fraction arguments are sensible (e.g. not larger than 1 or smaller than 0) and error out if so.

Also, fix the units in MS_TI documentation (density is per cu. m not per sq. m)

Thanks - looks good. I've added a handful of in-line comments. If you could change things and push to your branch it will show up here. Also, any chance of...

Except what we actually return in SF and SS is the eigenvectors projected onto the plane normal to the propagation direction (we return S1P and S2P calculated from: ``` %...

When this is fixed, we should also deal with the use case in MS_rotRandom and test_MS_rotRandom