andrewsml

Can no longer compile on Windows, "gn gen" can't parse arguments properly

2

`e build` command fails because `gn gen` can't parse command line arguments properly. it seems that something with quotation marks or escaping. ``` e build electron:dist Running "C:\Users\ElectronBuildMachine\.electron_build_tools\third_party\depot_tools\gn.bat gen out/Release...

fix: e sync, compare paths with no case

2

Closes https://github.com/electron/build-tools/issues/588 Path returned by `git rev-parse --show-toplevel` after normalizing contain C: drive in upper case, so further string comparison fails

`e sync` command fails due to git root mistmatch (Windows 10)

2

this happen by running `e sync` command. it compares two pathes and the only difference is that C: drive is in uppercase ``` ________ running 'python3 build/config/siso/configure_siso.py --rbe_instance projects/rbe-chrome-untrusted/instances/default_instance' in...

`e sync` command fails on macOS

6

`e sync` no longer works, using with fresh config. ``` sudo e init electron-release -i release --root=./src sudo e sync Error: Key 'deps' error: Key 'src/third_party/llvm-build/Release+Asserts' error: Or(None, , ,...