build-tools icon indicating copy to clipboard operation
build-tools copied to clipboard

fix: e sync, compare paths with no case

Open andrewsml opened this issue 1 year ago • 2 comments

Closes https://github.com/electron/build-tools/issues/588

Path returned by git rev-parse --show-toplevel after normalizing contain C: drive in upper case, so further string comparison fails

andrewsml avatar May 06 '24 10:05 andrewsml

@MarshallOfSound , Is it fine to make such a patch only for the Windows platform, like that? https://github.com/electron/build-tools/pull/589/commits/76d42800d6a59452434d090d88693952e28db310

andrewsml avatar May 07 '24 10:05 andrewsml

@andrewsml This PR is now ready to go but we require PRs to this (and some other Electron repos) to come with signed commits. Please set that up, or we can extract this PR into a new one with signed commits from a different auther

MarshallOfSound avatar May 25 '24 23:05 MarshallOfSound