Andrew O'Malley

Results 7 comments of Andrew O'Malley

Thanks for the pull request. I'm not sure about introducing a hard dependency on >= Java 8 in the core module. Will need to think about it a bit

It's more a limitation at the moment. There's no reason it can't be made to support nulls. Although it does create a few logical issues around things like `SortedSet` -...

Maybe try using a custom naming convention that applies quotes: https://github.com/andrewoma/kwery/blob/dc29a45cf4f5fe9232829f2ce9297a0dc63257e8/mapper/src/main/kotlin/com/github/andrewoma/kwery/mapper/TableConfiguration.kt#L26

Sounds a bit surprising. I'll have a look tomorrow my time

Sorry @ilya-g, I missed your questions. > I didn't follow, how comes that choosing the implementations carefully could render builders unnecessary? If using equivalents to Scala collections, builders do not...

@GlenKPeterson I'm pretty sure Scala's Vector doesn't support random insertion. From memory, it uses fixed arrays so it can calculate the exact location of an element without having to search.

> For example, java.util.ArrayList has add operation with O(1) complexity. Does it give the false impression about remove operation's O(n) complexity to the user? @ilya-g Fair point. I associate `Builder`...