Andrew Lock

Results 1518 comments of Andrew Lock

## Benchmarks Report for appsec :snail: Benchmarks for #5717 compared to [master](https://github.com/DataDog/dd-trace-dotnet/tree/0f912fefdd124405fe162c99458c9103ada53d82): * All benchmarks have **the same** speed * 2 benchmarks have **more** allocations The following thresholds were used...

## Benchmarks Report for tracer :snail: Benchmarks for #5717 compared to [master](https://github.com/DataDog/dd-trace-dotnet/tree/0f912fefdd124405fe162c99458c9103ada53d82): * 1 benchmarks are **faster**, with geometric mean 1.135 * 3 benchmarks are **slower**, with geometric mean 1.148...

## Throughput/Crank Report:zap: Throughput results for AspNetCoreSimpleController comparing the following branches/commits: - [This PR (5717)](https://github.com/DataDog/dd-trace-dotnet/tree/93022722b7b2a6805378ca83005ae272a556deef) - [master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953) - [benchmarks/2.9.0](https://github.com/DataDog/dd-trace-dotnet/tree/89ae3f4ee7d85b824badda5873166707c9e560b4) Cases where throughput results for the PR are worse than latest...

Hey, I did see it thanks, just on holiday at the moment ☺️ if I haven't replies in a couple of weeks, feel free to give me another nudge πŸ˜…

Hey @tiesmaster, just read through the description, and it all looks good to me in general. With regards to your proposal for supporting multiple attributes, I agree, we should probably...

Thanks for all your work @tiesmaster - appreciate it! I'll cut a new version shortly πŸ™‚

## Execution-Time Benchmarks Report :stopwatch: Execution-time results for samples comparing the following branches/commits: - [This PR (5550)](https://github.com/DataDog/dd-trace-dotnet/tree/0ad7a8be71fa15c0310eeea7b866389bd24b6737) - [master](https://github.com/DataDog/dd-trace-dotnet/tree/a82834fc88fffb0ef30e7f45c760600b3064e747) Execution-time benchmarks measure the whole time it takes to execute a...

## Benchmarks Report for tracer :snail: Benchmarks for #5550 compared to [master](https://github.com/DataDog/dd-trace-dotnet/tree/a82834fc88fffb0ef30e7f45c760600b3064e747): * 1 benchmarks are **faster**, with geometric mean 1.186 * 3 benchmarks are **slower**, with geometric mean 1.142...

## Throughput/Crank Report :zap: Throughput results for AspNetCoreSimpleController comparing the following branches/commits: - [This PR (5550)](https://github.com/DataDog/dd-trace-dotnet/tree/89d35c65a1c92cbf5c4ef6af29376f1447bc9b5a) - [master](https://github.com/DataDog/dd-trace-dotnet/tree/3b7c3f5c0cf45ce401cb1dfa70e1ca2578272b93) - [benchmarks/2.9.0](https://github.com/DataDog/dd-trace-dotnet/tree/89ae3f4ee7d85b824badda5873166707c9e560b4) Cases where throughput results for the PR are worse than...

## Benchmarks Report for appsec :snail: Benchmarks for #5550 compared to [master](https://github.com/DataDog/dd-trace-dotnet/tree/a82834fc88fffb0ef30e7f45c760600b3064e747): * 1 benchmarks are **slower**, with geometric mean 1.157 * 1 benchmarks have **fewer** allocations The following thresholds...