dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard
verified publisher icon DataDog

Config refactor - Add telemetry to otel config

Open andrewlock opened this issue 1 year ago • 5 comments

Summary of changes

Records logs and metrics for when otel config is overriden by datadog config, or when it's invalid

Reason for change

This was originally part of https://github.com/DataDog/dd-trace-dotnet/pull/5661, but wasn't possible due to concerns with the fact ConfigurationBuilder is used in critical "startup" paths for the tracer, so can result in recursion if we're not careful.

Implementation details

The crux of the implementation is that we "store" error and metrics for writing at the point we know it's safe. This is similar to what we already do for configuration telemetry.

(Technically I think we Could directly access the TelemetryFactory.Metrics, but this is "safer", and makes it easier to test we're sending the right metrics

Test coverage

Added unit tests to all of the existing settings tests where we override configuration to confirm that it works as expected

Other details

The metrics etc are all ported from https://github.com/DataDog/dd-trace-dotnet/pull/5661, but there are currently some issues with the proposed values:

  • [ ] The metrics aren't added to the intake yet, so need updating there (and copying here)
  • [ ] The tag names aren't "valid" for standard telemetry metrics, they should be lowercase, and shouldn't use .. I would suggest changing these to be lowercase and replacing . with _, but either way this should happen after they've been OK'd in the intake.

Part of a big ole stack:

  • https://github.com/DataDog/dd-trace-dotnet/pull/5713
  • https://github.com/DataDog/dd-trace-dotnet/pull/5714
  • https://github.com/DataDog/dd-trace-dotnet/pull/5715
  • https://github.com/DataDog/dd-trace-dotnet/pull/5716
  • https://github.com/DataDog/dd-trace-dotnet/pull/5717 (this PR)

andrewlock avatar Jun 20 '24 13:06 andrewlock

Datadog Report

Branch report: andrew/config-refactor/5-record-otel-telemetry Commit report: 7327595 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 341923 Passed, 1751 Skipped, 16h 14m 21.19s Total Time :hourglass: 1 Performance Regression

:hourglass: Performance Regressions vs Default Branch (1)

  • CallTarget+Inlining+NGEN - Samples.FakeDbCommand.windows.net60.json.scenarios 774.04ms (+81.2ms, +12%) - Details

datadog-ddstaging[bot] avatar Jun 20 '24 13:06 datadog-ddstaging[bot]

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5717) - mean (73ms)  : 65, 82
     .   : milestone, 73,
    master - mean (74ms)  : 64, 84
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (5717) - mean (1,071ms)  : 1051, 1092
     .   : milestone, 1071,
    master - mean (1,063ms)  : 1041, 1084
     .   : milestone, 1063,


gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5717) - mean (110ms)  : 104, 116
     .   : milestone, 110,
    master - mean (110ms)  : 105, 115
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (5717) - mean (750ms)  : 728, 773
     .   : milestone, 750,
    master - mean (747ms)  : 727, 767
     .   : milestone, 747,


gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5717) - mean (93ms)  : 88, 97
     .   : milestone, 93,
    master - mean (92ms)  : 88, 96
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (5717) - mean (774ms)  : crit, 609, 940
     .   : crit, milestone, 774,
    master - mean (703ms)  : 684, 721
     .   : milestone, 703,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5717) - mean (192ms)  : 188, 195
     .   : milestone, 192,
    master - mean (192ms)  : 189, 196
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (5717) - mean (1,169ms)  : 1145, 1194
     .   : milestone, 1169,
    master - mean (1,169ms)  : 1139, 1200
     .   : milestone, 1169,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5717) - mean (275ms)  : 272, 279
     .   : milestone, 275,
    master - mean (275ms)  : 271, 280
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (5717) - mean (923ms)  : 885, 960
     .   : milestone, 923,
    master - mean (921ms)  : 896, 947
     .   : milestone, 921,


gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5717) - mean (265ms)  : 261, 269
     .   : milestone, 265,
    master - mean (266ms)  : 262, 270
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (5717) - mean (909ms)  : 882, 936
     .   : milestone, 909,
    master - mean (905ms)  : 883, 928
     .   : milestone, 905,

andrewlock avatar Jun 20 '24 13:06 andrewlock

Benchmarks Report for appsec :snail:

Benchmarks for #5717 compared to master:

  • All benchmarks have the same speed
  • 2 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 72.6μs 107ns 416ns 0.0723 0 0 6 KB
master AllCycleSimpleBody netcoreapp3.1 63.6μs 102ns 381ns 0.0648 0 0 6.95 KB
master AllCycleSimpleBody net472 48.2μs 45.4ns 164ns 1.32 0 0 8.33 KB
master AllCycleMoreComplexBody net6.0 77.2μs 107ns 400ns 0.116 0 0 9.51 KB
master AllCycleMoreComplexBody netcoreapp3.1 69.6μs 121ns 470ns 0.139 0 0 10.36 KB
master AllCycleMoreComplexBody net472 56.2μs 75.6ns 293ns 1.88 0.028 0 11.85 KB
master ObjectExtractorSimpleBody net6.0 139ns 0.0911ns 0.341ns 0.00394 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 201ns 0.155ns 0.579ns 0.00376 0 0 272 B
master ObjectExtractorSimpleBody net472 163ns 0.119ns 0.445ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 3.14μs 1.46ns 5.67ns 0.0535 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 3.84μs 2.28ns 8.55ns 0.0502 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 3.89μs 2.2ns 8.52ns 0.602 0.0058 0 3.8 KB
#5717 AllCycleSimpleBody net6.0 72.9μs 150ns 560ns 0.0726 0 0 6 KB
#5717 AllCycleSimpleBody netcoreapp3.1 62.3μs 103ns 399ns 0.0617 0 0 6.95 KB
#5717 AllCycleSimpleBody net472 49μs 57.2ns 221ns 1.3 0 0 8.34 KB
#5717 AllCycleMoreComplexBody net6.0 77.8μs 109ns 421ns 0.117 0 0 9.51 KB
#5717 AllCycleMoreComplexBody netcoreapp3.1 69.5μs 116ns 447ns 0.139 0 0 10.37 KB
#5717 AllCycleMoreComplexBody net472 55.2μs 57.4ns 222ns 1.86 0.0274 0 11.85 KB
#5717 ObjectExtractorSimpleBody net6.0 144ns 0.517ns 2ns 0.00396 0 0 280 B
#5717 ObjectExtractorSimpleBody netcoreapp3.1 222ns 0.215ns 0.804ns 0.00369 0 0 272 B
#5717 ObjectExtractorSimpleBody net472 168ns 0.139ns 0.539ns 0.0446 0 0 281 B
#5717 ObjectExtractorMoreComplexBody net6.0 3.09μs 2.25ns 8.42ns 0.0524 0 0 3.78 KB
#5717 ObjectExtractorMoreComplexBody netcoreapp3.1 3.96μs 2.49ns 9.64ns 0.0496 0 0 3.69 KB
#5717 ObjectExtractorMoreComplexBody net472 3.87μs 2.29ns 8.88ns 0.602 0.00582 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 39.1μs 21.3ns 82.6ns 0.448 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 54μs 16.4ns 59ns 0.431 0 0 32.4 KB
master EncodeArgs net472 65.1μs 30.2ns 113ns 5.16 0.0653 0 32.5 KB
master EncodeLegacyArgs net6.0 72.9μs 410ns 2.9μs 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 109μs 79.2ns 307ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 155μs 98.9ns 383ns 0.307 0 0 2.15 KB
#5717 EncodeArgs net6.0 38.5μs 18.5ns 71.7ns 0.461 0 0 32.4 KB
#5717 EncodeArgs netcoreapp3.1 54.1μs 29.3ns 114ns 0.43 0 0 32.4 KB
#5717 EncodeArgs net472 66.1μs 46.5ns 180ns 5.15 0.066 0 32.5 KB
#5717 EncodeLegacyArgs net6.0 73.9μs 151ns 587ns 0 0 0 2.14 KB
#5717 EncodeLegacyArgs netcoreapp3.1 103μs 136ns 527ns 0 0 0 2.14 KB
#5717 EncodeLegacyArgs net472 154μs 196ns 761ns 0.309 0 0 2.15 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 186μs 62.3ns 241ns 0 0 0 2.42 KB
master RunWafRealisticBenchmark netcoreapp3.1 199μs 188ns 728ns 0 0 0 2.37 KB
master RunWafRealisticBenchmark net472 209μs 55.4ns 200ns 0.311 0 0 2.43 KB
master RunWafRealisticBenchmarkWithAttack net6.0 122μs 70.5ns 273ns 0 0 0 1.46 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 131μs 210ns 815ns 0 0 0 1.45 KB
master RunWafRealisticBenchmarkWithAttack net472 140μs 26.7ns 104ns 0.209 0 0 1.48 KB
#5717 RunWafRealisticBenchmark net6.0 185μs 466ns 1.74μs 0 0 0 2.42 KB
#5717 RunWafRealisticBenchmark netcoreapp3.1 198μs 190ns 737ns 0 0 0 2.37 KB
#5717 RunWafRealisticBenchmark net472 210μs 74.7ns 289ns 0.315 0 0 2.43 KB
#5717 RunWafRealisticBenchmarkWithAttack net6.0 122μs 91.9ns 356ns 0 0 0 1.46 KB
#5717 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 129μs 65.6ns 254ns 0 0 0 1.45 KB
#5717 RunWafRealisticBenchmarkWithAttack net472 139μs 59.4ns 230ns 0.207 0 0 1.48 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5717

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 254.01 KB 263.56 KB 9.55 KB 3.76%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 59.06 KB 59.36 KB 304 B 0.51%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 58.9μs 779ns 7.67μs 0 0 0 43.44 KB
master StringConcatBenchmark netcoreapp3.1 61.5μs 737ns 7.25μs 0 0 0 42.64 KB
master StringConcatBenchmark net472 37.5μs 98.2ns 354ns 0 0 0 59.06 KB
master StringConcatAspectBenchmark net6.0 292μs 5.72μs 56.9μs 0 0 0 254.2 KB
master StringConcatAspectBenchmark netcoreapp3.1 310μs 5.17μs 51.2μs 0 0 0 254.01 KB
master StringConcatAspectBenchmark net472 280μs 6.22μs 60.6μs 0 0 0 278.53 KB
#5717 StringConcatBenchmark net6.0 58.8μs 788ns 7.85μs 0 0 0 43.44 KB
#5717 StringConcatBenchmark netcoreapp3.1 53.7μs 232ns 1.04μs 0 0 0 42.64 KB
#5717 StringConcatBenchmark net472 38μs 154ns 578ns 0 0 0 59.36 KB
#5717 StringConcatAspectBenchmark net6.0 306μs 1.73μs 12.1μs 0 0 0 255.2 KB
#5717 StringConcatAspectBenchmark netcoreapp3.1 344μs 1.87μs 10.6μs 0 0 0 263.56 KB
#5717 StringConcatAspectBenchmark net472 291μs 7.36μs 70.6μs 0 0 0 278.53 KB

andrewlock avatar Jun 20 '24 16:06 andrewlock

Benchmarks Report for tracer :snail:

Benchmarks for #5717 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.135
  • 3 benchmarks are slower, with geometric mean 1.148
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.68μs 43.7ns 321ns 0.0113 0.00376 0 5.43 KB
master StartStopWithChild netcoreapp3.1 10μs 55.3ns 336ns 0.0282 0.0141 0 5.62 KB
master StartStopWithChild net472 15.9μs 51ns 197ns 1.02 0.306 0.0943 6.07 KB
#5717 StartStopWithChild net6.0 7.6μs 42.2ns 260ns 0.0154 0.00768 0 5.43 KB
#5717 StartStopWithChild netcoreapp3.1 9.79μs 53.6ns 303ns 0.019 0.00475 0 5.62 KB
#5717 StartStopWithChild net472 15.8μs 53.8ns 208ns 0.998 0.277 0.0792 6.07 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 466μs 437ns 1.63μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 602μs 239ns 894ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 819μs 368ns 1.27μs 0.411 0 0 3.3 KB
#5717 WriteAndFlushEnrichedTraces net6.0 486μs 391ns 1.51μs 0 0 0 2.7 KB
#5717 WriteAndFlushEnrichedTraces netcoreapp3.1 636μs 178ns 643ns 0 0 0 2.7 KB
#5717 WriteAndFlushEnrichedTraces net472 863μs 2.1μs 8.12μs 0.437 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 207μs 1.19μs 9.71μs 0.221 0 0 18.45 KB
master SendRequest netcoreapp3.1 227μs 1.31μs 11.7μs 0.222 0 0 20.61 KB
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#5717 SendRequest net6.0 208μs 1.5μs 14.8μs 0.213 0 0 18.45 KB
#5717 SendRequest netcoreapp3.1 229μs 1.34μs 12.5μs 0.225 0 0 20.61 KB
#5717 SendRequest net472 0.000464ns 0.000397ns 0.00154ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 575μs 2.98μs 15.8μs 0.324 0 0 41.55 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 706μs 4.1μs 35.5μs 0.355 0 0 41.64 KB
master WriteAndFlushEnrichedTraces net472 852μs 3.55μs 13.7μs 8.45 2.53 0.422 53.3 KB
#5717 WriteAndFlushEnrichedTraces net6.0 555μs 2.02μs 7.29μs 0.581 0 0 41.51 KB
#5717 WriteAndFlushEnrichedTraces netcoreapp3.1 698μs 3.96μs 27.4μs 0.343 0 0 41.81 KB
#5717 WriteAndFlushEnrichedTraces net472 898μs 4.33μs 17.8μs 8.09 2.25 0.45 53.31 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.19μs 0.788ns 2.95ns 0.0143 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.73μs 1.42ns 5.1ns 0.0139 0 0 1.02 KB
master ExecuteNonQuery net472 2.11μs 2.45ns 9.48ns 0.156 0 0 987 B
#5717 ExecuteNonQuery net6.0 1.31μs 1.36ns 5.28ns 0.0144 0 0 1.02 KB
#5717 ExecuteNonQuery netcoreapp3.1 1.65μs 1.42ns 5.3ns 0.0139 0 0 1.02 KB
#5717 ExecuteNonQuery net472 1.97μs 2.56ns 9.92ns 0.156 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #5717

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.128 1,175.21 1,325.51

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.1μs 0.69ns 2.67ns 0.0138 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.52μs 0.89ns 3.45ns 0.0129 0 0 976 B
master CallElasticsearch net472 2.48μs 3.74ns 14.5ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.17μs 0.661ns 2.47ns 0.0135 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.67μs 0.921ns 3.44ns 0.0132 0 0 1.02 KB
master CallElasticsearchAsync net472 2.72μs 3.46ns 13.4ns 0.167 0 0 1.05 KB
#5717 CallElasticsearch net6.0 1.1μs 0.528ns 2.05ns 0.0138 0 0 976 B
#5717 CallElasticsearch netcoreapp3.1 1.48μs 1.78ns 6.4ns 0.0135 0 0 976 B
#5717 CallElasticsearch net472 2.49μs 2.75ns 10.6ns 0.157 0 0 995 B
#5717 CallElasticsearchAsync net6.0 1.32μs 0.989ns 3.83ns 0.0133 0 0 952 B
#5717 CallElasticsearchAsync netcoreapp3.1 1.58μs 0.552ns 2.14ns 0.0135 0 0 1.02 KB
#5717 CallElasticsearchAsync net472 2.63μs 3.25ns 12.6ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.25μs 0.536ns 2.01ns 0.0131 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.64μs 1.82ns 6.8ns 0.0123 0 0 952 B
master ExecuteAsync net472 1.72μs 0.559ns 2.17ns 0.145 0 0 915 B
#5717 ExecuteAsync net6.0 1.2μs 0.998ns 3.86ns 0.0134 0 0 952 B
#5717 ExecuteAsync netcoreapp3.1 1.66μs 0.807ns 3.02ns 0.0124 0 0 952 B
#5717 ExecuteAsync net472 1.75μs 0.505ns 1.82ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.2μs 1.91ns 6.88ns 0.0318 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.09μs 3.22ns 12ns 0.0357 0 0 2.76 KB
master SendAsync net472 7.71μs 2.19ns 8.48ns 0.496 0 0 3.15 KB
#5717 SendAsync net6.0 4.16μs 1.64ns 6.34ns 0.0312 0 0 2.22 KB
#5717 SendAsync netcoreapp3.1 5.12μs 1.28ns 4.77ns 0.0358 0 0 2.76 KB
#5717 SendAsync net472 7.66μs 1.67ns 6.26ns 0.499 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.58μs 0.703ns 2.72ns 0.0227 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.09μs 0.662ns 2.39ns 0.0215 0 0 1.64 KB
master EnrichedLog net472 2.69μs 1.28ns 4.95ns 0.249 0 0 1.57 KB
#5717 EnrichedLog net6.0 1.46μs 0.402ns 1.56ns 0.0228 0 0 1.64 KB
#5717 EnrichedLog netcoreapp3.1 2.09μs 0.848ns 3.17ns 0.022 0 0 1.64 KB
#5717 EnrichedLog net472 2.56μs 0.943ns 3.53ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 114μs 203ns 786ns 0.0565 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 119μs 314ns 1.22μs 0.0592 0 0 4.28 KB
master EnrichedLog net472 147μs 134ns 518ns 0.663 0.221 0 4.46 KB
#5717 EnrichedLog net6.0 116μs 171ns 664ns 0.0581 0 0 4.28 KB
#5717 EnrichedLog netcoreapp3.1 119μs 225ns 873ns 0 0 0 4.28 KB
#5717 EnrichedLog net472 149μs 106ns 382ns 0.669 0.223 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.11μs 0.98ns 3.67ns 0.0311 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.24μs 1.39ns 5.2ns 0.0298 0 0 2.2 KB
master EnrichedLog net472 4.69μs 0.957ns 3.71ns 0.321 0 0 2.02 KB
#5717 EnrichedLog net6.0 2.96μs 0.463ns 1.73ns 0.031 0 0 2.2 KB
#5717 EnrichedLog netcoreapp3.1 4.13μs 0.882ns 3.3ns 0.0289 0 0 2.2 KB
#5717 EnrichedLog net472 4.76μs 0.868ns 3.36ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Faster :tada: Same allocations :heavy_check_mark:

Faster :tada: in #5717

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 1.135 1,429.58 1,259.45

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.43μs 0.74ns 2.77ns 0.0163 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.7μs 0.647ns 2.51ns 0.0152 0 0 1.14 KB
master SendReceive net472 2.06μs 1.18ns 4.55ns 0.183 0.00103 0 1.16 KB
#5717 SendReceive net6.0 1.26μs 0.872ns 3.38ns 0.0157 0 0 1.14 KB
#5717 SendReceive netcoreapp3.1 1.82μs 5.72ns 22.1ns 0.0153 0 0 1.14 KB
#5717 SendReceive net472 2.09μs 0.978ns 3.79ns 0.183 0.00105 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.73μs 0.984ns 3.68ns 0.0218 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.86μs 1.92ns 7.17ns 0.0213 0 0 1.65 KB
master EnrichedLog net472 4.47μs 5.13ns 19.9ns 0.322 0 0 2.04 KB
#5717 EnrichedLog net6.0 2.75μs 0.658ns 2.37ns 0.0222 0 0 1.6 KB
#5717 EnrichedLog netcoreapp3.1 3.93μs 1.18ns 4.58ns 0.0216 0 0 1.65 KB
#5717 EnrichedLog net472 4.42μs 3.81ns 14.8ns 0.324 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #5717

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 1.124 609.89 685.31

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 403ns 0.137ns 0.511ns 0.0081 0 0 576 B
master StartFinishSpan netcoreapp3.1 610ns 1.01ns 3.89ns 0.00766 0 0 576 B
master StartFinishSpan net472 664ns 0.661ns 2.56ns 0.0917 0 0 578 B
master StartFinishScope net6.0 496ns 0.0885ns 0.331ns 0.00973 0 0 696 B
master StartFinishScope netcoreapp3.1 755ns 0.391ns 1.51ns 0.00946 0 0 696 B
master StartFinishScope net472 902ns 1.23ns 4.75ns 0.104 0 0 658 B
#5717 StartFinishSpan net6.0 411ns 0.176ns 0.68ns 0.00809 0 0 576 B
#5717 StartFinishSpan netcoreapp3.1 686ns 0.596ns 2.23ns 0.00788 0 0 576 B
#5717 StartFinishSpan net472 667ns 3.24ns 13.4ns 0.0917 0 0 578 B
#5717 StartFinishScope net6.0 516ns 1.4ns 5.41ns 0.00984 0 0 696 B
#5717 StartFinishScope netcoreapp3.1 742ns 0.931ns 3.48ns 0.00936 0 0 696 B
#5717 StartFinishScope net472 853ns 0.608ns 2.27ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #5717

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.193 665.16 793.73

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 665ns 0.496ns 1.92ns 0.0097 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 994ns 0.912ns 3.53ns 0.00949 0 0 696 B
master RunOnMethodBegin net472 1.1μs 0.315ns 1.22ns 0.105 0 0 658 B
#5717 RunOnMethodBegin net6.0 794ns 0.298ns 1.15ns 0.00952 0 0 696 B
#5717 RunOnMethodBegin netcoreapp3.1 952ns 0.832ns 3.22ns 0.00914 0 0 696 B
#5717 RunOnMethodBegin net472 1.05μs 0.341ns 1.23ns 0.104 0 0 658 B

andrewlock avatar Jun 20 '24 18:06 andrewlock

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5717) (11.820M)   : 0, 11819641
    master (11.941M)   : 0, 11940953
    benchmarks/2.9.0 (11.959M)   : 0, 11959218

    section Automatic
    This PR (5717) (7.984M)   : 0, 7983558
    master (8.126M)   : 0, 8125742
    benchmarks/2.9.0 (8.424M)   : 0, 8423539

    section Trace stats
    master (8.463M)   : 0, 8462913

    section Manual
    This PR (5717) (10.213M)   : 0, 10212632
    master (10.295M)   : 0, 10294729

    section Manual + Automatic
    This PR (5717) (7.517M)   : 0, 7517347
    master (7.548M)   : 0, 7547543

    section Version Conflict
    master (6.848M)   : 0, 6848367


gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5717) (9.382M)   : 0, 9382173
    master (9.671M)   : 0, 9670503
    benchmarks/2.9.0 (9.647M)   : 0, 9646678

    section Automatic
    This PR (5717) (6.734M)   : 0, 6733673
    master (6.513M)   : 0, 6513280

    section Trace stats
    master (6.824M)   : 0, 6824339

    section Manual
    This PR (5717) (8.272M)   : 0, 8272072
    master (8.189M)   : 0, 8189017

    section Manual + Automatic
    This PR (5717) (6.213M)   : 0, 6213035
    master (6.236M)   : 0, 6235985

    section Version Conflict
    master (5.631M)   : 0, 5631298


gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5717) (10.189M)   : 0, 10188971
    master (10.108M)   : 0, 10107819
    benchmarks/2.9.0 (10.154M)   : 0, 10153990

    section Automatic
    This PR (5717) (7.302M)   : 0, 7301745
    master (7.230M)   : 0, 7230329
    benchmarks/2.9.0 (7.563M)   : 0, 7562893

    section Trace stats
    master (7.514M)   : 0, 7513930

    section Manual
    This PR (5717) (9.161M)   : 0, 9161480
    master (8.979M)   : 0, 8979416

    section Manual + Automatic
    This PR (5717) (7.002M)   : 0, 7001539
    master (6.821M)   : 0, 6820517

    section Version Conflict
    master (6.181M)   : 0, 6181437

andrewlock avatar Jun 21 '24 21:06 andrewlock