Andrew Leech
Andrew Leech
Interesting, I wonder if picocom does something different with the port opening process. The buffering stuff leans into a practice where detecting "port open" is done via DTR signal being...
The "correct" behaviour of that new buffering change _is_ to to keep the most recent "full stdout" buffer worth of data from before a terminal is connected for display on-connection....
Really strange! Was that after a soft reset or a hard boot? I'm wondering if there's some static buffers / memory pointers being reused without appropriate clearing on soft reset?...
This is now tested and working on both S2 and S3. I now consider it feature complete and ready for review.
Not quite sorry @dpgeorge I need to test them still.
Ok now it's re-tested on S2 and S3 with another rebase. I've fixed up based on review feedback and yes it all appears to work correctly without the polling of...
Thanks @dpgeorge thankfully the fix was easy to find and fairly obvious when looking at it! https://github.com/micropython/micropython/compare/c7d865170da1946b9dae2416dbed9fc0586fbd99..949495e5c0e370772883404c94a08f9bbba1aaf1#diff-e356b2686148d4a1bb2533f6af83551c711c223cca6e01e395ee91af6b255cb0 that diff would have been clearer if I hadn't rebased as well, but...
Thanks for the testing @dpgeorge that's a good outcome. I too would have thought faster speeds should be possible but that's still quite functional (and certainly better than UART) so...
Hi @dpgeorge this has been rebased now. Thanks for the review and useful comments @projectgus - I've implemented those suggestions too. Yeah I didn't love needing to hit the couple...
> This looks good to me! One non-critical note about the port header, but also please double-check the `ARDUINO_NANO_ESP32` config. I think [a6c35ae](https://github.com/micropython/micropython/commit/a6c35aeee873953bd9016cf63feb1a6772bdd6af) will need reverting here for it to...