Andrew Leech

Results 572 comments of Andrew Leech

@robert-hh FWIW I originally used their GUI tool to configure the clock domains and export the auto-gen code needed ![image](https://github.com/user-attachments/assets/32879cc8-c96b-4db8-928d-4c4a3c2847f7) I've since trimmed out all the extra / unused auto-gen...

Yeah I had to manually figure out & define the set of usb IRQ's myself by referencing the arduino board.

Ah yes it seems I rushed ahead with this, it was building previously before I went and consolidated some more settings to make UART and ble repl all work the...

Ah thanks for looking into that. I should make that define enabled by default if USB is enabled.

This has been rebased on master (still on top / including the startup buffer PR). I haven't yet re-tested it however.

Ah, I see now, those boards had just `MICROPY_HW_USB_CDC` defined, not `MICROPY_HW_ENABLE_USBDEV`. I think it makes sense more broadly to have `MICROPY_HW_ENABLE_USBDEV` as the "main" define to enable usb, so...

Ok that build failure: ``` LINK build-PCA10056-s140/firmware.elf /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: /tmp/firmware.elf.6R2Ffu.ltrans0.ltrans.o: in function `__wrap_dcd_event_handler': :(.text+0x3f3c): undefined reference to `dcd_event_handler' ``` Is caused by binutils: > [Bug 24406](https://sourceware.org/bugzilla/show_bug.cgi?id=24406) - -Wl,--wrap= incompatible with -flto...

Also thanks @robert-hh your reports made it clear there were a number of build failures on nrf52840 when `MICROPY_HW_USB_CDC = 1` but `MICROPY_HW_ENABLE_USBDEV = 0` I've cleaned them up too,...

Thanks I've rebased again onto master now my previous PR has been merged!

Thanks for the report and testing @robert-hh That's a shame, I thought I'd tested that change pretty thoroughly, looks like I missed some use cases though. I'll try to make...