Andrew Corcoran

Results 17 comments of Andrew Corcoran

I just spot checked ~10 different binaries linked with mold and only one of them didn't have this error. Caveat this with all these binaries are build as part of...

> @andrewkcorcoran > > Can you run `readelf -WS ` and paste its output here? ``` There are 45 section headers, starting at offset 0x329d000: Section Headers: [Nr] Name Type...

Details below. Just a thought but could the issue be related to RHEL devtoolset and the extra work it does to statically link the latest standard library calls to allow...

> @andrewkcorcoran https://godbolt.org/z/PzYs6861h Looks good. Unfortunately I don't think there's a way to make the solution generic (e.g. so the user could pass the work function into the switch as...

Looks good - if we're considering adding this into the library then we should probably using &&, std::forward, and std::invoke - https://godbolt.org/z/Y5K6bfboz

> https://godbolt.org/z/cGMjq3e6W maybe a more general case? No longer looks to be working correctly? e.g. no output to stdout

> I would add maybe two options(for_each & const_switch), but we should come up with concise names They both seem reasonable

Adding the below snippet to https://github.com/morganstanley/binlog/blob/main/include/binlog/default_session.hpp#L17 fixes the issue but I can't say I fully understand why as at first glance the code in that method looks thread safe to...

Interesting. I can't duplicate on either gcc or clang when adding my sample code into the binlog integration tests versus what was working before (having it as a standalone binary...

```bash $ git diff --staged diff --git a/CMakeLists.txt b/CMakeLists.txt index 859229b..828eedc 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -286,6 +286,15 @@ add_example(TscClock) message(STATUS "Build integration tests") + add_executable(ConcurrentSetId test/integration/ConcurrentSetId.cpp) + target_compile_definitions(ConcurrentSetId...