Andrew Corcoran

I guess the only other difference I can see is the compiler version - perhaps a false positive in clang 10? I don't currently have access to clang 11 -...

Any update on this? We've moved to clang 12 and gcc 11 and this error is occurring on both regularly (though not 100%)

I'm probably missing something obvious here but I'm getting compilation errors because the `ToStringVisitor::XXXBegin()` methods expect a `Range` as their second parameter but the methods in [mserialize/visit.cpp](https://github.com/morganstanley/binlog/blob/main/test/unit/mserialize/visit.cpp) are calling those...

Thanks, that makes sense. I had a look at the code and I think the sticking point may be the printf attribute checking. An I correct in saying all format...

We should support people consuming the library directly through CMake rather than through PkcConfig. https://cliutils.gitlab.io/modern-cmake/chapters/install.html

I don't think removing the googletest submodule is the correct way to go. Requiring a manual installation of gtest is just added work and has potential for breaking changes if...

Perhaps ci builds should be enabled for pull requests to master so? Looks like there's an option in the GitHub settings for that. It would avoid accidently merging a PR...

Any update on this? We've hit a few real cases where we've got multiple templates in concepts and are unable to log them.

In an ideal situation it would be great to be able to adapt without having to know the template specialisations e.g. `Derived::Nested2` instead of `Derived::Nested2`

Also we might want to add a requirement to support nested concepts e.g. ```cpp template struct S { struct S2{}; template concept C = requires(U u) {...}; }; BINLOG_ADAPT(S); BINLOG_ADAPT(S::S2);...