Andrew Baptist

Results 25 comments of Andrew Baptist

bors r=yuzefovich,kvoli TFTR!

In the test it is very close between the n3 is "fullly up" and n1 checking if it is alive. It probably published liveness a few ms earlier, but the...

Good point, it does read it from KV. However the write to KV happens here: https://github.com/cockroachdb/cockroach/blob/release-23.1/pkg/kv/kvserver/liveness/liveness.go#L798 inside the `RunAsyncTaskEx` loop, so it is possible the write hadn't happened by time...

As the tests are written today, many of them will fail with a single heartbeat failure which is unfortunate. I think the code in `upgradeStatus` Is too strict today and...