cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

kvclient: disable DistSQL for test

Open andrewbaptist opened this issue 9 months ago • 2 comments

DistSQL does not retry on setup errors. Ideally it would either work over partitions or retry while excluding the node rather than failing immediately during Inbox.Init.

Part of: #124246

Release note: None

andrewbaptist avatar May 15 '24 22:05 andrewbaptist

This change is Reviewable

cockroach-teamcity avatar May 15 '24 22:05 cockroach-teamcity

I don't think we need to backport, but at least this change ensures that DIstSender internally retries on partitions.

@yuzefovich - Do you have thoughts on whether we should attempt to change DistSQL to pass this test?

andrewbaptist avatar May 15 '24 22:05 andrewbaptist

Thansk @yuzefovich! I changed the Partitioner error to include rpc error and it works as you described.

andrewbaptist avatar May 16 '24 11:05 andrewbaptist

bors r=yuzefovich,kvoli

TFTR!

andrewbaptist avatar May 22 '24 14:05 andrewbaptist