Andrew Baptist

Results 25 comments of Andrew Baptist

@nvanbenschoten You are correct that we call `shedLease` more than we used to after https://github.com/cockroachdb/cockroach/commit/79886bb56a388b41c3dca327ba0d470d3b79b850. There are a check that occur before we call it. If the lease respect leaseholder...

@nvanbenschoten The call needed to be lifted because we don't always call `considerRebalance` anymore when processing a replica. We want to do is run the "important" action, and once that...

Yes it would be good to backport it - is it just a matter of adding the backport label to this? I'm not exactly sure of the process.

I was concerned about the impact of this change. I can easily disable all of these and will hold off on any backporting. I might need to rethink if there...

Will do - do you mean multiple PRs or multiple commits within a PR?

There was one problem - the https://github.com/dtolnay/unicode-ident project updated its license (it looks like maybe this is happening to all unicode libraries) so that it is no longer compatible with...

OK - split into 5 commits now - any more doesn't seem to make much sense.